ibm-openbmc / openbmc

https://github.com
Other
19 stars 51 forks source link

1050.00: Update `fault identify` & `identify` association #268

Open lxwinspur opened 1 year ago

lxwinspur commented 1 year ago

Update the association configuration of identify[1] & fault identify[2] according to the latest association interface.

[1] https://github.com/openbmc/phosphor-dbus-interfaces/commit/9eb460c6cfc2d7c2feb29c86f4beb31d4c3d9250 [2] https://github.com/openbmc/phosphor-dbus-interfaces/commit/e7c10bd5cdab6cd898e5cad0daab8c1128adc0c8

upstream: https://gerrit.openbmc.org/c/openbmc/openbmc/+/61068 https://gerrit.openbmc.org/c/openbmc/openbmc/+/61069

jenkins-openbmc-ibm commented 1 year ago

Can one of the admins verify this patch?

lxwinspur commented 1 year ago

@geissonator @anoo1 @baemyung @gtmills

Please take a look at this patch. BTW, sorry, I do not have permission to actively add reviewers.

lxwinspur commented 1 year ago

@rfrandse Please take a look at this issue, thanks

anoo1 commented 1 year ago

Seems these changes weren't merged and now @rfrandse started to do a rebase against the Mickledore branch upstream which has these LED changes: https://github.com/openbmc/openbmc/tree/mickledore

So once he rebases the ibm-openbmc/1050.00 branch we can verify the changes have been picked up and close this PR.

gtmills commented 1 year ago

jenkins run tests please

gtmills commented 1 year ago

add to approvelist