search

ibm-openbmc / openbmc

https://github.com
Other
19 stars 51 forks source link

1050: Move changeLogo.sh to /usr/bin #284

Closed lxwinspur closed 1 year ago

lxwinspur commented 1 year ago

Fixes https://github.com/ibm-openbmc/dev/issues/3629

jenkins-openbmc-ibm commented 1 year ago

Can one of the admins verify this patch?

gtmills commented 1 year ago

add to approvelist

gtmills commented 1 year ago

544618 is the internal defect

geissonator commented 1 year ago

We got an internal failure building this:

ERROR: webui-vue-1.0+gitAUTOINC+b661b9be80-r1 do_package: QA Issue: webui-vue: Files/directories were installed but not shipped in any package:
  /usr/bin
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.

Please look at this and be sure to add a "Tested:" to the commit msg indicating what testing was done (basically verify it compiles and script is in expected location)

gtmills commented 1 year ago

@lxwinspur Could you push this changeLogo stuff to upstream meta-ibm ? Lower priority but would be good to not have to carry..

gtmills commented 1 year ago

Reed pulled this into our GitHub Enterprise and merged it. Closing this and the issue. Thanks for the help here!