ibm-openbmc / openbmc

https://github.com
Other
19 stars 51 forks source link

Fix bbappend file failed to load sensor yaml #285

Closed lxwinspur closed 1 year ago

lxwinspur commented 1 year ago

Since phosphor-ipmi-host has been migrated to meson, the sensor yaml is incorrectly configured in the phosphor-ipmi-host_%.bbappend file in the 1050 branch, resulting in a failure to load, and the default configuration in the example is used.

Fixes https://github.com/ibm-openbmc/dev/issues/3625

jenkins-openbmc-ibm commented 1 year ago

Can one of the admins verify this patch?

gtmills commented 1 year ago

add to approvelist

gtmills commented 1 year ago

jenkins run tests please

gtmills commented 1 year ago

@lxwinspur This also fixes https://github.com/ibm-openbmc/dev/issues/3630, correct?

lxwinspur commented 1 year ago

@lxwinspur This also fixes https://github.com/ibm-openbmc/dev/issues/3630, correct?

Yes, I think so But I dont know why CI fails?

geissonator commented 1 year ago

This CI doesn't work, I've disabled it now. So we can ignore the CI fail here. @rfrandse has been putting manually through downstream CI to make sure they work.

gtmills commented 1 year ago

@lxwinspur Can this go upstream?

gtmills commented 1 year ago

Reed pulled this into GHE and merged it. It would be great if this went upstream @lxwinspur Thanks for the help here

rfrandse commented 1 year ago

passed downstream CI job and I merged in the downstream repository.

lxwinspur commented 1 year ago

It would be great if this went upstream

Sure :)