ibm-openbmc / openpower-hw-isolation

Apache License 2.0
0 stars 10 forks source link

openbmc CI does not pass on this repo due to libdt-api dep #46

Open geissonator opened 1 year ago

geissonator commented 1 year ago

This dependency is not something the CI docker infrastructure can find. Probably need to do something like hw-diags via https://grok.openbmc.org/xref/openbmc/openpower-hw-diags/util/meson.build?r=bb90afc7#21. They make it an option that by default is off in repo CI, and enabled via a bitbake flag in the recipe.

The Meson build system
Version: 0.63.0
Source dir: /home/andrewg/Code/openbmc-ghe/build/p10bmc/workspace/sources/openpower-hw-isolation
Build dir: /home/andrewg/Code/openbmc-ghe/build/p10bmc/workspace/sources/openpower-hw-isolation/build
Build type: native build
Project name: hardware_isolation
Project version: 1.0.0
C compiler for the host machine: cc (gcc 12.2.0 "cc (Ubuntu 12.2.0-3ubuntu1) 12.2.0")
C linker for the host machine: cc ld.bfd 2.39
C++ compiler for the host machine: c++ (gcc 12.2.0 "c++ (Ubuntu 12.2.0-3ubuntu1) 12.2.0")
C++ linker for the host machine: c++ ld.bfd 2.39
Host machine cpu family: x86_64
Host machine cpu: x86_64
Found pkg-config: /usr/bin/pkg-config (0.29.2)
Run-time dependency fmt found: YES 9.1.0
Found CMake: /usr/bin/cmake (3.24.2)
Run-time dependency libdt-api found: NO (tried pkgconfig and cmake)

meson.build:19:0: ERROR: Dependency "libdt-api" not found, tried pkgconfig and cmake
RameshIyyar commented 1 year ago

meson.build:19:0: ERROR: Dependency "libdt-api" not found, tried pkgconfig and cmake

I think we need to add repo-specific dependencies into the CI but, all PHAL repo use Autotools as build tools so we need to add meson wrap for those dependencies - I am not sure if meson wrap will support other build tools or if we need to convert all PHAL repos into meson

Probably need to do something like hw-diags via https://grok.openbmc.org/xref/openbmc/openpower-hw-diags/util/meson.build?r=bb90afc7#21. They make it an option that by default is off in repo CI, and enabled via a bitbake flag in the recipe.

hmm I noticed that changes but we cannot do that for hw-isolation since its fully dependent on the PHAL repos I think hw-diags and dump have a build flag to disable phal to support p9 and I guess we did not enable that flag in the CI