search

ibm-openbmc / openpower-hw-isolation

Apache License 2.0
0 stars 10 forks source link

common: Return ocmb target instead of dimm #91

Closed SwethaParasa closed 3 weeks ago

SwethaParasa commented 4 months ago

As OCMB has Location code now, return OCMB target for fetching Location code instead of returning dimm target for adc, gpio_expander, pmic, mem_port and ocmb targets. Also, added a special check for OCMB pretty name to support bonnell.

Tested on Bonnell, DDR4 everest and DDR5 rainier.

Bonnell:

root@p10bmc:/tmp/test# guard -l
ID         | ERROR      | Type            | Path
0x00000001 | 0x50000513 | fatal           | physical:sys-0/node-0/ocmb_chip-4
0x00000002 | 0x50000513 | fatal           | physical:sys-0/node-0/ocmb_chip-5
0x00000003 | 0x50000513 | fatal           | physical:sys-0/node-0/ocmb_chip-6
0x00000004 | 0x50000513 | fatal           | physical:sys-0/node-0/ocmb_chip-7
0x00000005 | 0x50000513 | fatal           | physical:sys-0/node-0/ocmb_chip-4/mem_port-0
0x00000006 | 0x50000513 | fatal           | physical:sys-0/node-0/ocmb_chip-5/mem_port-0
0x00000007 | 0x50000513 | fatal           | physical:sys-0/node-0/ocmb_chip-6/mem_port-0
0x00000008 | 0x50000513 | fatal           | physical:sys-0/node-0/ocmb_chip-7/mem_port-0

Redfish:
swetha@IBM-PF3XHYG0:~$ curl -k -H "X-Auth-Token: $bmc_token" -X GET https://${bmc}/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries
{
  "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries",
  "@odata.type": "#LogEntryCollection.LogEntryCollection",
  "Description": "Collection of System Hardware Isolation Entries",
  "Members": [
    {
      "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries/1",
      "@odata.type": "#LogEntry.v1_9_0.LogEntry",
      "AdditionalDataURI": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/242/attachment",
      "Created": "2024-05-02T09:31:14+00:00",
      "EntryType": "Event",
      "Id": "1",
      "Links": {
        "OriginOfCondition": {
          "@odata.id": "/redfish/v1/Chassis/chassis/Assembly#/Assemblies/0"
        }
      },
      "Message": "OpenCAPI Memory Buffer 2A",
      "Name": "Hardware Isolation Entry",
      "Severity": "Critical"
    },
    {
      "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries/2",
      "@odata.type": "#LogEntry.v1_9_0.LogEntry",
      "AdditionalDataURI": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/242/attachment",
      "Created": "2024-05-02T09:33:21+00:00",
      "EntryType": "Event",
      "Id": "2",
      "Links": {
        "OriginOfCondition": {
          "@odata.id": "/redfish/v1/Chassis/chassis/Assembly#/Assemblies/0"
        }
      },
      "Message": "OpenCAPI Memory Buffer 2A",
      "Name": "Hardware Isolation Entry",
      "Severity": "Critical"
    },
    {
      "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries/3",
      "@odata.type": "#LogEntry.v1_9_0.LogEntry",
      "AdditionalDataURI": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/242/attachment",
      "Created": "2024-05-02T09:33:54+00:00",
      "EntryType": "Event",
      "Id": "3",
      "Links": {
        "OriginOfCondition": {
          "@odata.id": "/redfish/v1/Chassis/chassis/Assembly#/Assemblies/0"
        }
      },
      "Message": "OpenCAPI Memory Buffer 2A",
      "Name": "Hardware Isolation Entry",
      "Severity": "Critical"
    },
    {
      "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries/4",
      "@odata.type": "#LogEntry.v1_9_0.LogEntry",
      "AdditionalDataURI": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/242/attachment",
      "Created": "2024-05-02T09:34:10+00:00",
      "EntryType": "Event",
      "Id": "4",
      "Links": {
        "OriginOfCondition": {
          "@odata.id": "/redfish/v1/Chassis/chassis/Assembly#/Assemblies/0"
        }
      },
      "Message": "OpenCAPI Memory Buffer 2A",
      "Name": "Hardware Isolation Entry",
      "Severity": "Critical"
    },
    {
      "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries/5",
      "@odata.type": "#LogEntry.v1_9_0.LogEntry",
      "AdditionalDataURI": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/242/attachment",
      "Created": "2024-05-02T10:01:04+00:00",
      "EntryType": "Event",
      "Id": "5",
      "Links": {
        "OriginOfCondition": {
          "@odata.id": "/redfish/v1/Chassis/chassis/Assembly#/Assemblies/0"
        }
      },
      "Message": "DDR Memory Port 2A",
      "Name": "Hardware Isolation Entry",
      "Severity": "Critical"
    },
    {
      "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries/6",
      "@odata.type": "#LogEntry.v1_9_0.LogEntry",
      "AdditionalDataURI": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/242/attachment",
      "Created": "2024-05-02T10:01:23+00:00",
      "EntryType": "Event",
      "Id": "6",
      "Links": {
        "OriginOfCondition": {
          "@odata.id": "/redfish/v1/Chassis/chassis/Assembly#/Assemblies/0"
        }
      },
      "Message": "DDR Memory Port 2A",
      "Name": "Hardware Isolation Entry",
      "Severity": "Critical"
    },
    {
      "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries/7",
      "@odata.type": "#LogEntry.v1_9_0.LogEntry",
      "AdditionalDataURI": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/242/attachment",
      "Created": "2024-05-02T10:01:37+00:00",
      "EntryType": "Event",
      "Id": "7",
      "Links": {
        "OriginOfCondition": {
          "@odata.id": "/redfish/v1/Chassis/chassis/Assembly#/Assemblies/0"
        }
      },
      "Message": "DDR Memory Port 2A",
      "Name": "Hardware Isolation Entry",
      "Severity": "Critical"
    },
    {
      "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries/8",
      "@odata.type": "#LogEntry.v1_9_0.LogEntry",
      "AdditionalDataURI": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/242/attachment",
      "Created": "2024-05-02T10:01:44+00:00",
      "EntryType": "Event",
      "Id": "8",
      "Links": {
        "OriginOfCondition": {
          "@odata.id": "/redfish/v1/Chassis/chassis/Assembly#/Assemblies/0"
        }
      },
      "Message": "DDR Memory Port 2A",
      "Name": "Hardware Isolation Entry",
      "Severity": "Critical"
    }
  ],
  "Members@odata.count": 8,
  "Name": "Hardware Isolation Entries"
}

DDR4 Everest:

root@p10bmc:/tmp/test# guard -l
ID         | ERROR      | Type            | Path
0x00000001 | 0x500814d8 | fatal           | physical:sys-0/node-0/ocmb_chip-34
0x00000002 | 0x500814d8 | fatal           | physical:sys-0/node-0/ocmb_chip-33/mem_port-0
0x00000003 | 0x500814d8 | fatal           | physical:sys-0/node-0/generic_i2c_device-129
0x00000004 | 0x500814d8 | fatal           | physical:sys-0/node-0/generic_i2c_device-130
0x00000005 | 0x500814d8 | fatal           | physical:sys-0/node-0/pmic-130
0x00000006 | 0x500814d8 | fatal           | physical:sys-0/node-0/dimm-71

Redfish:
swetha@IBM-PF3XHYG0:~$ curl -k -H "X-Auth-Token: $bmc_token" -X GET https://${bmc}/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries
{
  "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries",
  "@odata.type": "#LogEntryCollection.LogEntryCollection",
  "Description": "Collection of System Hardware Isolation Entries",
  "Members": [
    {
      "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries/1",
      "@odata.type": "#LogEntry.v1_9_0.LogEntry",
      "AdditionalDataURI": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/1/attachment",
      "Created": "2024-05-02T10:56:49+00:00",
      "EntryType": "Event",
      "Id": "1",
      "Links": {
        "OriginOfCondition": {
          "@odata.id": "/redfish/v1/Systems/system/Memory/dimm34"
        }
      },
      "Message": "OpenCAPI Memory Buffer",
      "Name": "Hardware Isolation Entry",
      "Severity": "Critical"
    },
    {
      "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries/2",
      "@odata.type": "#LogEntry.v1_9_0.LogEntry",
      "AdditionalDataURI": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/1/attachment",
      "Created": "2024-05-02T10:58:16+00:00",
      "EntryType": "Event",
      "Id": "2",
      "Links": {
        "OriginOfCondition": {
          "@odata.id": "/redfish/v1/Systems/system/Memory/dimm33"
        }
      },
      "Message": "DDR Memory Port",
      "Name": "Hardware Isolation Entry",
      "Severity": "Critical"
    },
    {
      "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries/3",
      "@odata.type": "#LogEntry.v1_9_0.LogEntry",
      "AdditionalDataURI": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/1/attachment",
      "Created": "2024-05-02T10:59:01+00:00",
      "EntryType": "Event",
      "Id": "3",
      "Links": {
        "OriginOfCondition": {
          "@odata.id": "/redfish/v1/Systems/system/Memory/dimm32"
        }
      },
      "Message": "Onboard Memory Power Control Device",
      "Name": "Hardware Isolation Entry",
      "Severity": "Critical"
    },
    {
      "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries/4",
      "@odata.type": "#LogEntry.v1_9_0.LogEntry",
      "AdditionalDataURI": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/1/attachment",
      "Created": "2024-05-02T10:59:22+00:00",
      "EntryType": "Event",
      "Id": "4",
      "Links": {
        "OriginOfCondition": {
          "@odata.id": "/redfish/v1/Systems/system/Memory/dimm32"
        }
      },
      "Message": "Onboard Memory Power Control Device",
      "Name": "Hardware Isolation Entry",
      "Severity": "Critical"
    },
    {
      "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries/5",
      "@odata.type": "#LogEntry.v1_9_0.LogEntry",
      "AdditionalDataURI": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/1/attachment",
      "Created": "2024-05-02T10:59:51+00:00",
      "EntryType": "Event",
      "Id": "5",
      "Links": {
        "OriginOfCondition": {
          "@odata.id": "/redfish/v1/Systems/system/Memory/dimm32"
        }
      },
      "Message": "Onboard Memory Power Management IC",
      "Name": "Hardware Isolation Entry",
      "Severity": "Critical"
    },
    {
      "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries/6",
      "@odata.type": "#LogEntry.v1_9_0.LogEntry",
      "AdditionalDataURI": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/1/attachment",
      "Created": "2024-05-02T11:00:43+00:00",
      "EntryType": "Event",
      "Id": "6",
      "Links": {
        "OriginOfCondition": {
          "@odata.id": "/redfish/v1/Systems/system/Memory/dimm35"
        }
      },
      "Message": "Memory module 35",
      "Name": "Hardware Isolation Entry",
      "Severity": "Critical"
    }
  ],
  "Members@odata.count": 6,
  "Name": "Hardware Isolation Entries"
}

DDR5 rainier:

sh-5.2# guard -l
ID         | ERROR      | Type            | Path
0x00000001 | 0x5000b452 | fatal           | physical:sys-0/node-0/dimm-61
0x00000002 | 0x5000b452 | fatal           | physical:sys-0/node-0/ocmb_chip-25
0x00000003 | 0x5000b452 | fatal           | physical:sys-0/node-0/ocmb_chip-30/mem_port-0
0x00000004 | 0x5000b452 | fatal           | physical:sys-0/node-0/pmic-125
0x00000005 | 0x5000b452 | fatal           | physical:sys-0/node-0/dimm-62

Redfish:
swetha@IBM-PF3XHYG0:~$ curl -k -H "X-Auth-Token: $bmc_token" -X GET https://${bmc}/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries
{
  "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries",
  "@odata.type": "#LogEntryCollection.LogEntryCollection",
  "Description": "Collection of System Hardware Isolation Entries",
  "Members": [
    {
      "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries/1",
      "@odata.type": "#LogEntry.v1_9_0.LogEntry",
      "AdditionalDataURI": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/3084/attachment",
      "Created": "2024-05-02T11:27:55+00:00",
      "EntryType": "Event",
      "Id": "1",
      "Links": {
        "OriginOfCondition": {
          "@odata.id": "/redfish/v1/Systems/system/Memory/dimm30"
        }
      },
      "Message": "Memory module 27",
      "Name": "Hardware Isolation Entry",
      "Severity": "Critical"
    },
    {
      "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries/2",
      "@odata.type": "#LogEntry.v1_9_0.LogEntry",
      "AdditionalDataURI": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/3084/attachment",
      "Created": "2024-05-02T11:28:39+00:00",
      "EntryType": "Event",
      "Id": "2",
      "Links": {
        "OriginOfCondition": {
          "@odata.id": "/redfish/v1/Systems/system/Memory/dimm25"
        }
      },
      "Message": "OpenCAPI Memory Buffer",
      "Name": "Hardware Isolation Entry",
      "Severity": "Critical"
    },
    {
      "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries/3",
      "@odata.type": "#LogEntry.v1_9_0.LogEntry",
      "AdditionalDataURI": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/3084/attachment",
      "Created": "2024-05-02T11:29:10+00:00",
      "EntryType": "Event",
      "Id": "3",
      "Links": {
        "OriginOfCondition": {
          "@odata.id": "/redfish/v1/Systems/system/Memory/dimm30"
        }
      },
      "Message": "DDR Memory Port",
      "Name": "Hardware Isolation Entry",
      "Severity": "Critical"
    },
    {
      "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries/4",
      "@odata.type": "#LogEntry.v1_9_0.LogEntry",
      "AdditionalDataURI": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/3084/attachment",
      "Created": "2024-05-02T11:30:23+00:00",
      "EntryType": "Event",
      "Id": "4",
      "Links": {
        "OriginOfCondition": {
          "@odata.id": "/redfish/v1/Systems/system/Memory/dimm31"
        }
      },
      "Message": "Onboard Memory Power Management IC",
      "Name": "Hardware Isolation Entry",
      "Severity": "Critical"
    },
    {
      "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries/5",
      "@odata.type": "#LogEntry.v1_9_0.LogEntry",
      "AdditionalDataURI": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/3084/attachment",
      "Created": "2024-05-02T11:31:10+00:00",
      "EntryType": "Event",
      "Id": "5",
      "Links": {
        "OriginOfCondition": {
          "@odata.id": "/redfish/v1/Systems/system/Memory/dimm31"
        }
      },
      "Message": "Memory module 28",
      "Name": "Hardware Isolation Entry",
      "Severity": "Critical"
    }
  ],
  "Members@odata.count": 5,
  "Name": "Hardware Isolation Entries"
}

Change-Id: I594c83a8fe2b7ddafdd1df31c488d27402dcc57a Signed-off-by: Parasa Swetha Parasa.Swetha1@ibm.com