Closed SwethaParasa closed 4 months ago
As OCMB has Location code now, return OCMB target for fetching Location code instead of returning dimm target for adc, gpio_expander, pmic, mem_port and ocmb targets. Also, added a special check for OCMB pretty name to support bonnell.
Test Results: Tested on Bonnell, DDR5 Rainier
Bonnell:
root@p10bmc:/tmp/test# guard -l ID | ERROR | Type | Path 0x00000001 | 0x5000142c | predictive | physical:sys-0/node-0/ocmb_chip-7 0x00000002 | 0x5000142c | predictive | physical:sys-0/node-0/ocmb_chip-7/mem_port-0 0x00000003 | 0x5000142c | predictive | physical:sys-0/node-0/ocmb_chip-6/mem_port-0 0x00000004 | 0x5000142c | predictive | physical:sys-0/node-0/ocmb_chip-5/mem_port-0 0x00000005 | 0x5000142c | predictive | physical:sys-0/node-0/ocmb_chip-4/mem_port-0 0x00000006 | 0x5000142c | predictive | physical:sys-0/node-0/ocmb_chip-4 0x00000007 | 0x5000142c | predictive | physical:sys-0/node-0/ocmb_chip-5 0x00000008 | 0x5000142c | predictive | physical:sys-0/node-0/ocmb_chip-6
Redfish:
swetha@IBM-PF3XHYG0:~$ curl -k -H "X-Auth-Token: $bmc_token" -X GET https://${bmc}/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entri es { "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries", "@odata.type": "#LogEntryCollection.LogEntryCollection", "Description": "Collection of System Hardware Isolation Entries", "Members": [ { "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries/1", "@odata.type": "#LogEntry.v1_9_0.LogEntry", "AdditionalDataURI": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/2/attachment", "Created": "2024-05-10T14:30:51+00:00", "EntryType": "Event", "Id": "1", "Links": { "OriginOfCondition": { "@odata.id": "/redfish/v1/Chassis/chassis/Assembly#/Assemblies/0" } }, "Message": "OpenCAPI Memory Buffer 3B", "Name": "Hardware Isolation Entry", "Severity": "Warning" }, { "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries/2", "@odata.type": "#LogEntry.v1_9_0.LogEntry", "AdditionalDataURI": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/2/attachment", "Created": "2024-05-10T14:43:42+00:00", "EntryType": "Event", "Id": "2", "Links": { "OriginOfCondition": { "@odata.id": "/redfish/v1/Chassis/chassis/Assembly#/Assemblies/0" } }, "Message": "DDR Memory Port 3B", "Name": "Hardware Isolation Entry", "Severity": "Warning" }, { "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries/3", "@odata.type": "#LogEntry.v1_9_0.LogEntry", "AdditionalDataURI": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/2/attachment", "Created": "2024-05-10T14:43:59+00:00", "EntryType": "Event", "Id": "3", "Links": { "OriginOfCondition": { "@odata.id": "/redfish/v1/Chassis/chassis/Assembly#/Assemblies/0" } }, "Message": "DDR Memory Port 3A", "Name": "Hardware Isolation Entry", "Severity": "Warning" }, { "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries/4", "@odata.type": "#LogEntry.v1_9_0.LogEntry", "AdditionalDataURI": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/2/attachment", "Created": "2024-05-10T14:44:08+00:00", "EntryType": "Event", "Id": "4", "Links": { "OriginOfCondition": { "@odata.id": "/redfish/v1/Chassis/chassis/Assembly#/Assemblies/0" } }, "Message": "DDR Memory Port 2B", "Name": "Hardware Isolation Entry", "Severity": "Warning" }, { "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries/5", "@odata.type": "#LogEntry.v1_9_0.LogEntry", "AdditionalDataURI": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/2/attachment", "Created": "2024-05-10T14:44:17+00:00", "EntryType": "Event", "Id": "5", "Links": { "OriginOfCondition": { "@odata.id": "/redfish/v1/Chassis/chassis/Assembly#/Assemblies/0" } }, "Message": "DDR Memory Port 2A", "Name": "Hardware Isolation Entry", "Severity": "Warning" }, { "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries/6", "@odata.type": "#LogEntry.v1_9_0.LogEntry", "AdditionalDataURI": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/2/attachment", "Created": "2024-05-10T14:44:58+00:00", "EntryType": "Event", "Id": "6", "Links": { "OriginOfCondition": { "@odata.id": "/redfish/v1/Chassis/chassis/Assembly#/Assemblies/0" } }, "Message": "OpenCAPI Memory Buffer 2A", "Name": "Hardware Isolation Entry", "Severity": "Warning" }, { "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries/7", "@odata.type": "#LogEntry.v1_9_0.LogEntry", "AdditionalDataURI": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/2/attachment", "Created": "2024-05-10T14:45:09+00:00", "EntryType": "Event", "Id": "7", "Links": { "OriginOfCondition": { "@odata.id": "/redfish/v1/Chassis/chassis/Assembly#/Assemblies/0" } }, "Message": "OpenCAPI Memory Buffer 2B", "Name": "Hardware Isolation Entry", "Severity": "Warning" }, { "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries/8", "@odata.type": "#LogEntry.v1_9_0.LogEntry", "AdditionalDataURI": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/2/attachment", "Created": "2024-05-10T14:45:18+00:00", "EntryType": "Event", "Id": "8", "Links": { "OriginOfCondition": { "@odata.id": "/redfish/v1/Chassis/chassis/Assembly#/Assemblies/0" } }, "Message": "OpenCAPI Memory Buffer 3A", "Name": "Hardware Isolation Entry", "Severity": "Warning" } ], "Members@odata.count": 8, "Name": "Hardware Isolation Entries" }
DDR5 Rainier:
root@p10bmc:/tmp/test# guard -l ID | ERROR | Type | Path 0x00000001 | 0x50000482 | predictive | physical:sys-0/node-0/ocmb_chip-31 0x00000002 | 0x50000482 | predictive | physical:sys-0/node-0/ocmb_chip-30/mem_port-1 0x00000003 | 0x50000482 | predictive | physical:sys-0/node-0/dimm-59 0x00000004 | 0x50000482 | predictive | physical:sys-0/node-0/pmic-121
swetha@IBM-PF3XHYG0:~$ curl -k -H "X-Auth-Token: $bmc_token" -X GET https://${bmc}/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entri es { "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries", "@odata.type": "#LogEntryCollection.LogEntryCollection", "Description": "Collection of System Hardware Isolation Entries", "Members": [ { "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries/1", "@odata.type": "#LogEntry.v1_9_0.LogEntry", "AdditionalDataURI": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/1063/attachment", "Created": "2024-05-14T09:49:52+00:00", "EntryType": "Event", "Id": "1", "Links": { "OriginOfCondition": { "@odata.id": "/redfish/v1/Systems/system/Memory/dimm31" } }, "Message": "OpenCAPI Memory Buffer", "Name": "Hardware Isolation Entry", "Severity": "Warning" }, { "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries/2", "@odata.type": "#LogEntry.v1_9_0.LogEntry", "AdditionalDataURI": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/1063/attachment", "Created": "2024-05-14T09:50:26+00:00", "EntryType": "Event", "Id": "2", "Links": { "OriginOfCondition": { "@odata.id": "/redfish/v1/Systems/system/Memory/dimm30" } }, "Message": "DDR Memory Port", "Name": "Hardware Isolation Entry", "Severity": "Warning" }, { "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries/3", "@odata.type": "#LogEntry.v1_9_0.LogEntry", "AdditionalDataURI": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/1063/attachment", "Created": "2024-05-14T09:51:11+00:00", "EntryType": "Event", "Id": "3", "Links": { "OriginOfCondition": { "@odata.id": "/redfish/v1/Systems/system/Memory/dimm29" } }, "Message": "Memory module 29", "Name": "Hardware Isolation Entry", "Severity": "Warning" }, { "@odata.id": "/redfish/v1/Systems/system/LogServices/HardwareIsolation/Entries/4", "@odata.type": "#LogEntry.v1_9_0.LogEntry", "AdditionalDataURI": "/redfish/v1/Systems/system/LogServices/EventLog/Entries/1063/attachment", "Created": "2024-05-14T09:51:59+00:00", "EntryType": "Event", "Id": "4", "Links": { "OriginOfCondition": { "@odata.id": "/redfish/v1/Systems/system/Memory/dimm30" } }, "Message": "Onboard Memory Power Management IC", "Name": "Hardware Isolation Entry", "Severity": "Warning" } ], "Members@odata.count": 4, "Name": "Hardware Isolation Entries" }
Change-Id: I594c83a8fe2b7ddafdd1df31c488d27402dcc57a Signed-off-by: Parasa Swetha Parasa.Swetha1@ibm.com
As OCMB has Location code now, return OCMB target for fetching Location code instead of returning dimm target for adc, gpio_expander, pmic, mem_port and ocmb targets. Also, added a special check for OCMB pretty name to support bonnell.
Test Results: Tested on Bonnell, DDR5 Rainier
Bonnell:
Redfish:
DDR5 Rainier:
Redfish:
Change-Id: I594c83a8fe2b7ddafdd1df31c488d27402dcc57a Signed-off-by: Parasa Swetha Parasa.Swetha1@ibm.com