ibm-power-utilities / powerpc-utils

Suite of utilities for Linux on Power systems
GNU General Public License v2.0
34 stars 55 forks source link

drmgr: raise log rotation threshold #53

Closed nathanlynch closed 3 years ago

nathanlynch commented 3 years ago

The log rotation threshold is a mere 25000 bytes:

dr_fini(void)
{
    struct stat sbuf;
    int max_dr_log_sz = 25000;
...
    rc = stat(DR_LOG_PATH, &sbuf);
...
    if (sbuf.st_size >= max_dr_log_sz) {
        fprintf(stderr, "Rotating logs...\n");
...

Raising the rotation limit to something like 1MB would help problem determination by preserving more history and would better accommodate higher detail levels (e.g. -d 15 to get librtas debug output).

tyreld commented 3 years ago

Fixed by commit 88ebfd97d1c4