Closed martinezjavier closed 2 years ago
@martinezjavier ping, what is the status of this PR? Are you going to address the last few change requests?
fyi, as there was no response since last year we've pulled the patches and adapted the requested style changes ourselves. Thanks for the contribution!
The target field is required for IPL sections, but the ones populated from BLS snippets did not have this field. This was only working when using BLS snippets because IPL sections inherit the target field with "defaultauto".
But that's not the case when using a menu, for example the following zipl configuration will fail if is used along with BLS defined IPL sections: fail when running the zipl tool:
[defaultboot] defaultmenu = menu1
:menu1 target = /boot 1 = linux 2 = test default = 1 prompt = 1 timeout = 0
Because "linux" and "test" will be defined using BLS snippets and these don't have an option to define target fields. Let's make these to always inherit a target field, either from the [defaultboot] section or a menu section if there's a defaultmenu defined.
Fixes: https://github.com/ibm-s390-linux/s390-tools/issues/111
Reported-by: Renaud Métrich rmetrich@redhat.com Signed-off-by: Javier Martinez Canillas javierm@redhat.com