search

ibm-s390-linux / s390-tools

Tools for use with the s390 Linux kernel and device drivers
MIT License
63 stars 59 forks source link

hsavmcore: fix the dependency evaluation #118

Closed sharkcz closed 3 years ago

sharkcz commented 3 years ago

Set the Makefile depedency similarily to cmsfs-fuse, so the overlay.c won't be recompiled during the "make install" phase.

ifranzki commented 3 years ago

check-dep-fuse is a dependency of overlay.o (and not 'all') for a good reason. I one calls make with target 'hsavmcore' only, then no fuse-checking would happen. The better solution would be to make check-dep-fuse a non-PHONY target, i.e. add touch check-dep-fuse to the end of the receipt of check-dep-fuse. That way it is executed only once (during compile of the code), but not anymore during make install.

sharkcz commented 3 years ago

That should likely work too, I am not insisting on my solution :-) But would be great ,if there would be consistency between the various tools/subdirs.

eaibmz commented 3 years ago

Thanks for reporting. Should be fixed in the next release. I went with the solution proposed by Ingo.

sharkcz commented 3 years ago

@eaibmz, do you have the patch available somewhere, so it could be integrated in our package? I would rather go with the upstream version, when it exists.

eaibmz commented 3 years ago

@eaibmz, do you have the patch available somewhere, so it could be integrated in our package? I would rather go with the upstream version, when it exists.

Here: https://github.com/eaibmz/s390-tools/commit/f21ec6f5ee853231c910fc48b8a6ab0f33aa255c

sharkcz commented 3 years ago

thanks :-)