search

ibm-s390-linux / s390-tools

Tools for use with the s390 Linux kernel and device drivers
MIT License
63 stars 60 forks source link

WIP: #5: rewrite zipl_helper in python. #12

Closed r4f4 closed 6 years ago

r4f4 commented 6 years ago

This is still a work in progress regarding issue #5. The C version would take longer than expected, so I did a python one in the meantime. Using python is still in line with the Fedora minimal baseruntime, since it is a dependency of some basic system tools (like dnf).

I tried to included some unit tests to make sure the helper works as expected. I'll continue testing and improving the test cases while upstream reviews this patch.

I would love some feedback before submitting the definitive version.

r4f4 commented 6 years ago

ping. Any comments on this?

michael-holzheu commented 6 years ago

ping. Any comments on this?

@r4f4 - sorry for the late reply.

Our strategy for s390-tools is to use C as the main language. Therefore we started converting tools (lsqeth, lsscm, lschp, chchp) to C and started with the internal "libutil" support library. Having only one language makes support much easier since all of our developers know C and sharing code is possible.

Up to now we don't have python in s390-tools. So if we go your way, this would add yet another language to the package which I really would like to avoid.

Therefore I would appreciate it if you could try to re-implement the script in C.

michael-holzheu commented 6 years ago

@oberpar @stefan-haberland @hoeppnerj : FYI

r4f4 commented 6 years ago

Ok. I'll keep working on the C version.

michael-holzheu commented 6 years ago

Ok. I'll keep working on the C version.

Great :+1:

michael-holzheu commented 6 years ago

Let's wait for the C version - closing this one.