search

ibm-s390-linux / s390-tools

Tools for use with the s390 Linux kernel and device drivers
MIT License
62 stars 58 forks source link

ziomon: remove the packed attribute from structs #141

Open sharkcz opened 1 year ago

sharkcz commented 1 year ago

Seem the use of attribute((packed)) for ziomon's structs is not required for proper function of ziomon, see discussion in PR #137. Review and remove the attribute from the code.

Benjamin-Block commented 1 year ago

@hoeppnerj probably better to assign this to @fedorloshakov, I'm just here to add my unqualified comments :wink:

But may that as it be, like I said in slack, I see value in this; if nothing else it should reduce some technical debt in ziomon by get rid of unnecessary, and thus confusing, attributes; if they turn out to be unnecessary upon closer evaluation.

Can't make any promises in terms of time-frame though. This doesn't have a very high priority IMHO.