search

ibm-s390-linux / s390-tools

Tools for use with the s390 Linux kernel and device drivers
MIT License
62 stars 58 forks source link

make -Werror optional, it breaks builds with new compiler #148

Closed sharkcz closed 1 year ago

sharkcz commented 1 year ago

Currently genprotimg, libpv and pvattest enforce use of -Werror in their Makefile and it is causing problems when for example new compiler (eg. gcc 13) is being used like in current Fedora 38 and Rawhide. Just using the glib.h header throws an error, see https://bugzilla.redhat.com/show_bug.cgi?id=2170551 for details. Generally it is discouraged using -Werror in production builds for exactly this reason by the toolchain people.

Thus I would like ask for providing an option to either disable or enable using -Werror parameter on the global level. For example with ENABLE_WERROR=1 for the top level make command, like there is ENABLE_DOC today.

sharkcz commented 1 year ago

Confirming the fix works and we can build s390utils with GCC 13 in Rawhide, thanks.