ibm-s390-linux / s390-tools

Tools for use with the s390 Linux kernel and device drivers
MIT License
63 stars 60 forks source link

rust folder as a rust workspace #156

Closed jcajka closed 10 months ago

jcajka commented 1 year ago

I would like to ask if rust folder with collection of crates can be made back to the rust workspace. Due to new approaches of the Fedora's rust packaging folks it would greatly ease and simplify packaging there along with IMHO easier vendoring handling.

steffen-eiden commented 1 year ago

IMO we can do this. If I am not mistaken @xnox wanted us to not use workspaces. Is that still the case?

If nothing stands against using workspaces I would add rust/Cargo.toml with the following content:

[workspace]

members = [
    "pv",
    "pvsecret",
    "utils",
]

[profile.release]
lto = true
panic = "abort"

In difference to the workspace from the POC I would not define dependencies here, but in the workspace members scope.

With this minimal definition one could just remove the new Cargo.toml and still be able to compile all the tools.

CC: @sharkcz @frank-heimes @ngueorguiev @hoeppnerj

frank-heimes commented 1 year ago

Yes, we would also like to see workspaces!

steffen-eiden commented 1 year ago

OK, I will create a patch adding workspaces. To be published before the next release.