search

ibm-s390-linux / s390-tools

Tools for use with the s390 Linux kernel and device drivers
MIT License
62 stars 58 forks source link

libpv: fix build with OpenSSL 1.1 #167

Closed sharkcz closed 3 months ago

sharkcz commented 3 months ago

OpenSSL 1.1 seems to use a non-const parameter to X509_name_dup(), but x509_armonk_locality_fixup() is passing a const there. The compile then fails on "discards 'const' qualifier", when -Werror is used. Thus resolve with a type-cast like in pv_c2b_name().

mhartmay commented 3 months ago

Hi Dan, LGTM. While at it... can you please fix it for genprotimg as well? [1]

[1] https://github.com/ibm-s390-linux/s390-tools/blob/master/genprotimg/src/utils/crypto.c#L771

sharkcz commented 3 months ago

Hi Dan, LGTM. While at it... can you please fix it for genprotimg as well? [1]

[1] https://github.com/ibm-s390-linux/s390-tools/blob/master/genprotimg/src/utils/crypto.c#L771

sure :-)

mhartmay commented 3 months ago

Thanks. Reviewed-by: Marc Hartmayer <mhartmay@linux.ibm.com> for both patches.