search

ibm-s390-linux / s390-tools

Tools for use with the s390 Linux kernel and device drivers
MIT License
62 stars 58 forks source link

zfcpdump: do not save timestamp when compressing #169

Closed frank-heimes closed 3 weeks ago

frank-heimes commented 1 month ago

Having timestamps in gzip leads to lintian warning 'package-contains-timestamped-gzip' and will harm reproducible builds. Gzip option '-n' avoids saving original file name and especially timestamp by default.

eaibmz commented 1 month ago

Hi, looks good to me but please add your explanation as a commit message. Thanks.

steffen-eiden commented 1 month ago

Thanks for your contribution.

LGTM

As @eaibmz mentioned, please add a short explanation.

Additionally we need your Signed-off-by: email@address <NAME> as part of the commit message.

Thanks!

frank-heimes commented 1 month ago

Updated (amended and force pushed) to this: https://github.com/ibm-s390-linux/s390-tools/commit/b47e6a2 Thx

steffen-eiden commented 1 month ago

Thank you!

Reviewed-by: Steffen Eiden <seiden@linux.ibm.com>

I'll pick this patch later when @eaibmz gave his r-b.

eaibmz commented 1 month ago

Reviewed-by: Alexander Egorenkov <egorenar@linux.ibm.com>