Open sertonix opened 1 month ago
Note: see https://gitlab.alpinelinux.org/alpine/aports/-/issues/16310 and https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/70132#note_426060 for further context.
Thanks for your contribution.
It makes sense to not use the size of a symbolic link.
A nit: Please start with a capital letter in your commit message:
netboot/mk-s390image: Fix size when argument is a symlink
LGTM
While you are at it:
Could you also add the -L
to line 138
- parmfile_size=$(du -b $parmfile | cut -f1)
+ parmfile_size=$(du -b -L $parmfile | cut -f1)
Thanks!
I applied all suggestions now
Thank you. I will pick the patch.
Note we do not use GH to apply pull requests.
du -b
by default returns the size of a symlink when it is passed a symlink. Adding the-L
option allows passing symlinks to mk-s390image without resulting in unbootable image.