search

ibm-s390-linux / s390-tools

Tools for use with the s390 Linux kernel and device drivers
MIT License
63 stars 60 forks source link

support autoloading kernel pkey module #51

Closed sharkcz closed 5 years ago

sharkcz commented 5 years ago

The module is loaded automatically based on CPU features, but it's still too late in some use cases. Thus allow distros to use explicit loading.

See also: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=63c19be095d0f8eb8992674991e44b4228bd4179

Signed-off-by: Dan Horák dan@danny.cz

@ifranzki

sharkcz commented 5 years ago

related to https://bugzilla.redhat.com/show_bug.cgi?id=1664632

ifranzki commented 5 years ago

I wonder if s390-pkey.conf should go into /etc/modules-load.d within the s390-tools tree? This somehow implies that it will also go into /etc/modules-load.d/ on the installed system, but I think it should rather go to /usr/lib/modules-load.d/. Of course the location within the s390-tool tree does not have to match the installation location, but I wonder if another location within the s390-tools tree wouldn't be better, to make it clearer that it should not go into /etc/modules_load.d, for example within /systemd directory? @hoeppnerj what do you think?

sharkcz commented 5 years ago

There are udev rules also under etc/udev/rules.d, but they are installed (by distros, not by make install) in /usr/lib/udev/... Thus I followed this with the modules-load.d.

hoeppnerj commented 5 years ago

We just discussed another possible solution which would, however, need a few clean ups. Your patch is fine for now and I'll integrate it. Thanks for the contribution.

sharkcz commented 5 years ago

Thanks as well :-)