search

ibm-s390-linux / s390-tools

Tools for use with the s390 Linux kernel and device drivers
MIT License
63 stars 60 forks source link

zipl: remove trailing spaces from the fields defined in BLS files #62

Closed martinezjavier closed 5 years ago

martinezjavier commented 5 years ago

Currently the zipl tool doesn't remove trailing spaces from the BLS field values. So for example if a 'title' field has trailing spaces and is used as the default, zipl will complain that there's no section with that name:

Using config file '/etc/zipl.conf' Using BLS config file '/boot/loader/entries/f871a0cf218348c5ba921f61c92b7eac-4.18.0-80.20.el8.s390x.conf' Using BLS config file '/boot/loader/entries/f871a0cf218348c5ba921f61c92b7eac-0-rescue.conf' Error: Config file '/etc/zipl.conf': Line 6: no such section 'Red Hat Enterprise Linux (4.18.0-80.20.el8.s390x) 8.1 (Ootpa)'

Since the trailing spaces are also removed from the fields defined in the zipl.conf file, do the same for the ones that are defined in the BLS file.

Signed-off-by: Javier Martinez Canillas javierm@redhat.com

stefan-haberland commented 5 years ago

Thanks for the patch. Looks good to me.