Closed cgwalters closed 3 years ago
Also of note, I didn't build or run this.
Hi Nikita @nikita-dubrovskii, could you help with this? Many thanks.
Hi Nikita @nikita-dubrovskii, could you help with this? Many thanks.
Hi, i've built FCOS this morning and installed it on zVM, system runs just fine. If you have any tests, please let me know.
[core@coreos ~]$ sudo rpm-ostree status
State: idle
Deployments:
* ostree://fedora:fedora/s390x/coreos/testing-devel
Version: 32.20201111.dev.0 (2020-11-11T10:13:26Z)
Commit: 918fc3ea29bae10cbd5cdac1da0f24558db5270309835ab571b0acc1ca072238
GPGSignature: (unsigned)
[core@coreos ~]$ systemctl --failed
UNIT LOAD ACTIVE SUB DESCRIPTION
0 loaded units listed.
[core@coreos ~]$ head /usr/lib/systemd/system/cpi.service -n18
# Service unit to apply control program identification (CPI) settings
#
# Copyright IBM Corp. 2017
#
# s390-tools is free software; you can redistribute it and/or modify
# it under the terms of the MIT license. See LICENSE for details.
#
[Unit]
Description=Apply Control Program Identification (CPI)
DefaultDependencies=no
Conflicts=shutdown.target
After=sysinit.target
ConditionPathIsReadWrite=/sys/firmware/cpi
[Service]
Type=oneshot
RemainAfterExit=yes
[core@coreos ~]$
Thanks for testing. Also, this seems to make sense, I'll pull it.
Noticed this while looking at the unit file for a different RHEL CoreOS issue.
See https://github.com/ostreedev/ostree/pull/1697 and https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=750683
Omitting this can cause the service to run multiple times if something else ends up depending on it, which I'm guessing we don't want.
Signed-off-by: Colin Walters walters@verbum.org