Turn off the Default Bucket in COS class

ibm-watson-data-lab / ibmos2spark

Facilitates Data I/O between Spark and IBM Object Storage services.

10 stars 8 forks source link

Open bassel-zeidan opened 7 years ago

bassel-zeidan commented 7 years ago

With Default Bucket:

Pros: easier since most of the time user wants to fetch data from the same bucket.
Cons: inconsistent with other classes

Without Default Bucket:

Pros: consistent with other classes.
Cons: 1) break libs that already use ibmos2spark when the change occurs directly on the url function (backward compatibility issue). 2) we lose the default Bucket value.

bassel-zeidan commented 7 years ago

If we decide to go with a change, we need to think of a way of how to maintain the backward compatibility of the lib.