search

ibm-watson-data-lab / sodashboard

Frontend for Stackoverflow Questions Data
1 stars 0 forks source link

Sync errors are not communicated to the end user #22

Closed ptitzler closed 7 years ago

ptitzler commented 7 years ago

CORS was accidentally disabled in the new Cloudant instance. When I opened the SOdashboard no SO data was displayed. Since it usually takes about 10 seconds for the load to complete I started to investigate after a little while by inspecting the network traffic. I discovered that a call to the Cloudant REST API returned error 401, indicating that the credentials were invalid. After CORS was enabled in Cloudant things worked as expected. We need to somehow critical expose sync issues to the end user.

mmcelaney commented 7 years ago

@vabarbosa will fu with @glynnbird on squashing this bug.

ptitzler commented 7 years ago

Bluemix toolchain: Delivery Pipeline deployed sodashboard to dev, including commit 53c7b2114af981f0179c115a8730f731b6a98dc5

ptitzler commented 7 years ago

Bluemix toolchain: Delivery Pipeline deployed sodashboard to wdp-infrastructure, including commit 53c7b2114af981f0179c115a8730f731b6a98dc5

glynnbird commented 7 years ago

I accidentally pushed the fix for this to the master, so now it's live without a review.

The sync error detection was actually already in the code, but it was displaying an icon that didn't exist. I've swapped this out for a red danger sign.

I thought about showing an alert with the error message but his is actually already console.logged to the console if we're interested. If you switch off your wifi, you can keep using sodashboard because you're working with a local PouchDB database.