search

ibmcb / cbtool

Cloud Rapid Experimentation and Analysis Toolkit
Apache License 2.0
78 stars 49 forks source link

fix MetricStoreMgdConnException issue #406

Closed vermavis closed 3 years ago

vermavis commented 3 years ago

We faced an issue within cb in which when the code path was touching this user-defined exception "MetricStoreMgdConnException" python3 complained with following msg:

"TypeError: catching classes that do not inherit from BaseException is not allowed."

Due to this, the client API object was getting hung and the client API kept waiting to receive something from the socket. This fixes the issue by using local version of MetricStoreMgdConnException class and because of that we no longer see that TypeError msg.

maugustosilva commented 3 years ago

This one looks good, and fixes a bug I was seeing too. Merged