search

ibmcb / cbtool

Cloud Rapid Experimentation and Analysis Toolkit
Apache License 2.0
79 stars 49 forks source link

Fix monextract #410

Closed jdesfossez closed 3 years ago

jdesfossez commented 3 years ago

There was the same issue about the MySQL exception handler that was fixed in 18d164d685af1a9b5de3e3c100e87b85c6b6359f

Then some typos (obj_attr_list -> _obj_attr_list).

And finally, some files need to be open with buffering.

Signed-off-by: Julien Desfossez jdesfossez@digitalocean.com

maugustosilva commented 3 years ago

Hi @jdesfossez. I had this fixed on PR #407 (it was required, otherwise a complete regression test wouldn't pass). Can you take a look that PR and tell me if you're ok with merging it? Many thanks in advance!

jdesfossez commented 3 years ago

Oh, right, I missed that ! I will review and update/close this PR accordingly.

jdesfossez commented 3 years ago

Ok, I updated this one with only the 2 small fixes missing from your branch. And rebased on top of your branch.