search

ibmcb / cbtool

Cloud Rapid Experimentation and Analysis Toolkit
Apache License 2.0
77 stars 49 forks source link

s/async/nosync for Python 3.8 #421

Closed mraygalaxy closed 2 years ago

mraygalaxy commented 2 years ago

I believe I've converted everything and also included command-line-level backwards compatibility (only) for 'async', just because old habits die hard.

But, anything that uses the API will need to switchover.

mraygalaxy commented 2 years ago

@jdesfossez @maugustosilva How does this look? Would you like to test the branch first?

jdesfossez commented 2 years ago

Hi Michael, thanks for this PR ! We just tested it and it works perfectly !

mraygalaxy commented 2 years ago

@jdesfossez Perfect, glad to hear it. @maugustosilva This is a pretty impactful change. Any objections?

mraygalaxy commented 2 years ago

@jdesfossez Marcio sounds a little busy right now, but I doubt he'd have any objections here. I'll go ahead and merge this as well.