search

ibmcb / cbtool

Cloud Rapid Experimentation and Analysis Toolkit
Apache License 2.0
79 stars 49 forks source link

Two issues with scripts/common/cb_cleanup.sh #447

Open rayx opened 4 months ago

rayx commented 4 months ago

While I use the following command to create cassandra_ycsb workload image, it fails consistently:

vmattach check:cb_nullworkload:ubuntu:nullworkload

The error log:

...
[2024-07-02 09:52:55,440] [INFO] dependencies.py/instance_preparation  - Running the instance cleanup script "/home/ubuntu/cbtool//scripts//common/cb_cleanup.sh"...
/home/ubuntu/cbtool//scripts//common/cb_cleanup.sh
Killed

The issue is caused by this line in scripts//common/cb_cleanup.sh:

blowawaypids redis

At the end of the vmattach command, it runs this command on vm

~/cbtool/pre_install.sh; ~/cbtool/install --role workload --wks nullworkload,cassandra_ycsb,mongo_ycsb,redis_ycsb

The install command invokes cb_cleanup.sh. And the above line kills install process by accident.

I don't understand why it's necessary to kill these processes in general (I don't think they have any effect on vmcapture command). I comment out the above code to work around this specific issue.

While I investigate it, I also notice another unrelated issue in the code:

blowawaypids -f gtkCBUI

The "-f" is a typo and should be removed.