ibmdb / node-ibm_db

IBM DB2 and IBM Informix bindings for node
MIT License
188 stars 151 forks source link

Replace unzip package to fix Node 18 install error #922

Closed t1m0thyj closed 1 year ago

t1m0thyj commented 1 year ago

Fixes #920 by replacing the problematic unzipper package (see https://github.com/ZJONSSON/node-unzipper/issues/271) with adm-zip.

The adm-zip package is actively maintained, popular with 3.5M weekly downloads, and lightweight with no dependencies.

It requires Node.js >=6 so I have updated the engines field in package.json accordingly. I don't think this should be a problem since Node versions older than 6 have been out of support for a long time.

Also, it doesn't use streams like unzipper did. I think this is a good change since extracting a ZIP archive using a stream is inherently unreliable due to the way ZIP files are structured (see https://github.com/thejoshwolfe/yauzl/issues/12).