search

ibmdb / node-ibm_db

IBM DB2 and IBM Informix bindings for node
MIT License
188 stars 151 forks source link

adm-zip can it be moved to dev dependencies #978

Closed huineng closed 5 months ago

huineng commented 5 months ago

Other then being used to do an install (build and install face) It's not really used

Can this be moved to the dev dependencies as such ?

It's not a big deal, it's just being reported as unused by contrast security when we use a ci/cd

thanks

bimalkjha commented 5 months ago

@huineng If we move it to dev, it will not get installed during installation of ibm_db and hence, installation of ibm_db will fail. So, let it be a dependency. There should be some way to ignore it by contrast security. Thanks.

huineng commented 5 months ago

ok, no problem