search

ibmjstart / bluemix-letsencrypt

Let's Encrypt wrapper for Cloud Foundry apps on IBM Bluemix
MIT License
36 stars 15 forks source link

Update to maintain compatibility with latest Bluemix CLI #2

Closed whereswaldon closed 7 years ago

whereswaldon commented 8 years ago

The usage for bx security cert-add no longer accepts domain names with host names (subdomains) attached. The setup-app.py file needs to be changed to invoke it correctly.

lmsurpre commented 8 years ago

It's also possible that we never properly tested with a domains.yml that contains only a single, non-root, host.

I think the cf-letsencrypt project was doing something interesting here where they prepend the first host to the domain name for some reason.

In most of my configurations, my first hosts entry was '.' and in that case the cf-letsencrypt tool would put the certs in a directory with the name of the domain (without prepending the host).

Anyway, regardless of the root cause, I agree we should clean this up.