ibmjstart / bluemix-letsencrypt

Let's Encrypt wrapper for Cloud Foundry apps on IBM Bluemix
MIT License
36 stars 15 forks source link

Script exits (without downloading certificates) due to 'tlsv1 unrecognized name' #8

Closed neocolmartin closed 7 years ago

neocolmartin commented 7 years ago

Bluemix appears to have given me an invalid SSL certificate by default on my custom domain, which is causing the script to fail as follows:

Waiting for certs...
Certs not ready yet, retrying in 5 seconds.
Making GET request to https://{domain omitted}
Traceback (most recent call last):
  File "setup-app.py", line 121, in <module>
    if domain_has_ssl(domain_with_first_host, True):
  File "setup-app.py", line 24, in domain_has_ssl
    return cert_exists or check_ssl(domain)
  File "setup-app.py", line 46, in check_ssl
    requests.get(target)
  File "/home/martin/.local/lib/python2.7/site-packages/requests/api.py", line 72, in get
    return request('get', url, params=params, **kwargs)
  File "/home/martin/.local/lib/python2.7/site-packages/requests/api.py", line 58, in request
    return session.request(method=method, url=url, **kwargs)
  File "/home/martin/.local/lib/python2.7/site-packages/requests/sessions.py", line 502, in request
    resp = self.send(prep, **send_kwargs)
  File "/home/martin/.local/lib/python2.7/site-packages/requests/sessions.py", line 612, in send
    r = adapter.send(request, **kwargs)
  File "/home/martin/.local/lib/python2.7/site-packages/requests/adapters.py", line 504, in send
    raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPSConnectionPool(host='{domain omitted}', port=443): Max retries exceeded with url: / (Caused by SSLError(SSLError("bad handshake: Error([('SSL routines', 'ssl3_read_bytes', 'tlsv1 unrecognized name')],)",),))

In theory I could upload the certificates manually, but the code to download the certificates is after the code to check for an existing SSL on the connection (which appears to be the wrong way round to me).

lmsurpre commented 7 years ago

Agree. Just committed a change to fix the ordering.