search

ibmresearchuk / node-red-bluemix-nodes

A collection of node-red nodes for the IBM Bluemix platform
Apache License 2.0
33 stars 36 forks source link

Remove Machine Translation and Language Identification #22

Closed germanattanasio closed 9 years ago

germanattanasio commented 9 years ago

Please remove the IBM Watson Machine Translation and Language Identification nodes. This is related to #19 which is the service that replaces them.

jthomas commented 9 years ago

That ticket was actually resolved with 56007e60d3414da3eb5c1dac766b23bdd96dd149. It's been left open accidentally, will sort that.

Looking at https://github.com/node-red/node-red-bluemix-nodes/blob/master/watson/lid.js#L56-L71 and https://github.com/node-red/node-red-bluemix-nodes/blob/master/watson/smt.js#L83-L89 I believe we are now using the correct methods.

Can you confirm?

germanattanasio commented 9 years ago

@jthomas that looks OK :bowtie: