ibmresilient / resilient-community-apps

Source code for IBM SOAR Apps that are available on our App Exchange
https://ibm.biz/soar-apps-docs
MIT License
91 stars 95 forks source link

Update exchange_utils.py #19

Closed jjfallete closed 5 years ago

jjfallete commented 5 years ago

Sets the email body type to HTML, enabling support for HTML tags within the body.

In a future release, create a Boolean input field to set the body type (HTML: Y/N).

Description

Sets the email body type to HTML, enabling support for HTML tags within the body.

Motivation and Context

Enables support for HTML tags within the body.

How Has This Been Tested?

Requires testing before deployment.

Checklist:

I have not done any of the following. I am new to this game.

Signed-off-by: I'll leave this for engineering...

jjfallete commented 5 years ago

My only question is what effect does encapsulating the body in html have for the email message. Are there situations where the html body will not get interpreted correctly?

This operates as standard HTML. Plaintext will correctly show up inside of the HTML tags.

From the testing I have done with this, the body as-is does not support native python string formatting (I specifically tried using \n -- it showed up literally), so I do not see concerns with the interpretation.

Can you confirm this?

jjfallete commented 5 years ago

Update on this:

I made this change in our local environment today. It was successful. I am now able to use HTML in the email bodies.