search

ibmresilient / resilient-community-apps

Source code for IBM SOAR Apps that are available on our App Exchange
https://ibm.biz/soar-apps-docs
MIT License
88 stars 96 forks source link

fn_ProofPoint_trap URL concatenation results in an incorrect url #48

Closed JasonMKane closed 4 years ago

JasonMKane commented 4 years ago

https://github.com/ibmresilient/resilient-community-apps/blob/8f4ffdebb5f0f5bf180ee22858b47bfaf681423b/fn_proofpoint_trap/fn_proofpoint_trap/lib/pptr_client.py#L142

The use of the urljoin function results in an incomplete URL at runtime. Using the example value for base_url in the README.md for fn_proofpoint_trap: https://192.168.1.1/api. Passing this through URL join will take remove the /api from the base_url in the app.config, and concatenate the route resulting in: https://192.168.1.1/incidents/123456.json (Bad Url) instead of https://192.168.1.1/api/incidents/123456.json

The resulting URL to the incident resource is incorrect.

EDIT: Removed failed attempt at markdown to highlight the missing /api in the URL.

breid1313 commented 4 years ago

Are you still having this issue? It looks like this was actually fixed in version 1.0.1, so if you upgrade via the App Exchange the integration should work.

JasonMKane commented 4 years ago

No we're no longer having this issue. I can confirm it was corrected in 1.0.1.