ibmresilient / resilient-community-apps

Source code for IBM SOAR Apps that are available on our App Exchange
https://ibm.biz/soar-apps-docs
MIT License
88 stars 96 forks source link

fn_datatable_utils-1.0.1 #60

Closed LiamMahoney closed 2 years ago

LiamMahoney commented 3 years ago

Description

Changing the 'Data Table Utils: Get Row' function to use .get() instead of bracket notation when accessing the values of a cell.

Motivation and Context

59

How Has This Been Tested?

Verified that a KeyError is no longer thrown with the new code

Checklist:

Signed-off-by: LiamMahoney liammahoney96@gmail.com

LiamMahoney commented 3 years ago

forgot to use git commit -S ... on https://github.com/ibmresilient/resilient-community-apps/pull/60/commits/702c4ff1d45a7a73bc9a386f9167f957e55b043d, that's why you see the force-push above.

LiamMahoney commented 3 years ago

Sweet, thanks Mark!

annmarien commented 2 years ago

I believe that this issue is fixed as the functions have been re-written in the 2.0.0 release. There is more error checking and .get is used. Thanks for submitting this fix Liam.