ibmresilient / resilient-community-apps

Source code for IBM SOAR Apps that are available on our App Exchange
https://ibm.biz/soar-apps-docs
MIT License
91 stars 95 forks source link

fn_outbound_email - missing input field to select attachments #64

Open gbernat opened 3 years ago

gbernat commented 3 years ago

Description

In version 1.0.0 release notes mention the added capability to select which incident attachments to include in the mail, however that input field is not show once the app is installed.

In the code it looks like everything is ready: components/send_mail.py: l.91 -> mail_attachments = kwargs.get("mail_attachments") #text (Get the function parameters)

The allowed options are evaluated in: l.187 -> def process_attachments(self, inc_id, attachments): (*: all, a list, or None)

Probably it only needs to run a new codegen --reload, to get an updated package.

In addition, maybe the reference to the class FunctionComponent in lines l.192 and l.196 is missing: Instead of: temp_attach(self, inc_id, incident_attachment_list, attachments, file_list)

Put: FunctionComponent.temp_attach(self, inc_id, incident_attachment_list, attachments, file_list)

Thanks!