Adding config option to skip the SSL certificate verification

smoreau commented 2 years ago

Description

The purpose of this change is to add a new configuration option to skip the SSL certificate verification. This is quite useful for non-production instances for example which often have self-signed certificates.

Motivation and Context

As explained in the description, the motivation of this change is to allow us to skip the SSL certificate verification for mainly non-production instances.

How Has This Been Tested?

It has been successfully tested on our test Resilient environment. We also did non-regression testing : if you do not add this option in the configuration file, it is still working as before.

Checklist:

[x] I have added a Signed-off-by
[x] Either no new documentation is required by this change, OR I added new documentation
[x] Either no new tests are required by this change, OR I added new tests
[x] I have run pep8 and pylint. I have cleaned up all valid errors and warnings in code I have added or modified. These tools may generate false positives. Don't be worried about ignoring some errors or warnings. The goal is clean, consistent, and readable code.

Signed-off-by: Stéphane Moreau smoreau@logikdev.com

smoreau commented 2 years ago

@sj-curtin would it be possible to have a status on this pull request please?

sj-curtin commented 2 years ago

Hi @smoreau,

Thank you for opening this PR

We have manually added the changes as we had to do some internal QA

Have just now updated our public repo too

We have also updated this app on our Exchange: https://exchange.xforce.ibmcloud.com/hub/extension/d85f32b1eaa5da9dd9fe13267b0bf607

Closing this PR now 😃

smoreau commented 2 years ago

Thanks a lot. 👍

ibmresilient / resilient-community-apps