initial ibmnode dockerfiles

ibmruntimes / ci.docker

Dockerfiles and build scripts for generating various Docker Images related to IBM Runtimes

Apache License 2.0

45 stars 35 forks source link

initial ibmnode dockerfiles #15

Closed BethGriggs closed 7 years ago

BethGriggs commented 7 years ago

[x] Add script to generate Dockerfiles
[x] Confirm legal approval to do silent installs
[x] Add license header
[x] Add README
[x] Add SHASUM check
[x] Refactor to match existing ibmnode docker image structure
[x] Provide a link to the license 'onbuild'

BethGriggs commented 7 years ago

@dinogun in response to your questions:

We will have a separate Dockerfile for Node4/Node6/Node8. We have one base Dockerfile that we intend to use as the template for other three (it includes moustache style templating for easy replacement).
I will add a README.
@Paul-Ivinson gave the initial OK (based on him seeing the Java Legal approvals) - however I will confirm whether or not anything specific is required for Node.
I will add the License header.

BethGriggs commented 7 years ago

I am not aware of any imminent plans for us to add alpine docker images for ibmnode, but we can always add an extra directory level if we ever need to.

gibfahn commented 7 years ago

Also are you planning on providing Alpine based images in the future ? If so, how do you plan to name the Dockerfiles.

See https://github.com/ibmruntimes/ci.docker/pull/15#discussion_r144951218

dinogun commented 7 years ago

Hi Bethany, Let me know if you have the legal clearances so that I can merge, thanks

gibfahn commented 7 years ago

Hi Bethany, Let me know if you have the legal clearances so that I can merge, thanks

@Paul-Ivinson could you let us know when the approvals are in?

BethGriggs commented 7 years ago

@dinogun , @Paul-Ivinson has confirmed we are good to go from the legal perspective.