ibmruntimes / openj9-openjdk-jdk

Extensions for OpenJDK for Eclipse OpenJ9
GNU General Public License v2.0
17 stars 75 forks source link

Use correct JNI function to call ArrayList.add() #720

Closed jasonkatonica closed 10 months ago

jasonkatonica commented 10 months ago

Various testcases are being run as part of the openj9 project. Currently one of these tests is failing since they are able to detect that the wrong method signature is being used by JNI calls at runtime.

This update makes the same method call only it expects a boolean to be returned from the method call. This allows for the test to pass the JNI method signature check.

This fixes openj9 issue 17795.

Signed-off-by: Jason Katonica katonica@us.ibm.com

pshipton commented 10 months ago

Pls refer to the issue this is fixing in the description.

pshipton commented 10 months ago

Pls add an IBM copyright statement for the change.

jasonkatonica commented 10 months ago

Pls refer to the issue this is fixing in the description.

Added a link to the issue being fixed in both the commit and PR descriptions.

pshipton commented 10 months ago

Ideally we should try to get OpenJDK to accept this change so this patch will become obsolete.

jasonkatonica commented 10 months ago

Please update the commit message. The summary should speak to what this change will do if it is merged (as opposed to the problem that exists now).

Updated the commit and PR descriptions with a new approach.

keithc-ca commented 10 months ago

The summary line of the commit message still describes the problem instead of the change. Instead of

JNI signature type incorrect when building NSS modules ArrayList

I suggest it should say something like

Use correct JNI function to call ArrayList.add()

jasonkatonica commented 10 months ago

The summary line of the commit message still describes the problem instead of the change. Instead of

JNI signature type incorrect when building NSS modules ArrayList

I suggest it should say something like

Use correct JNI function to call ArrayList.add()

Updated the summary line of both the PR and the commit itself with what was suggested.

keithc-ca commented 10 months ago

Jenkins compile amac jdknext

keithc-ca commented 10 months ago

Please back-port to jdk22, jdk21, jdk17, jdk11 and jdk8.