ibmruntimes / openj9-openjdk-jdk

Extensions for OpenJDK for Eclipse OpenJ9
GNU General Public License v2.0
17 stars 73 forks source link

Move getting native pointer to ECUtils and acquire during init #792

Closed KostasTsiounis closed 3 months ago

KostasTsiounis commented 3 months ago

The acquisition of a native pointer for an EC key, private or public, is being moved to the ECUtil, instead of the implementation classes of said keys. This allows use of interop keys, rather than just keys coming from SunEC.

The methods to get the pointers to the native keys are called during the initialization phases, to discover the possibility of not being able to utilize the native code and revert to the Java implementation early.

The engineUpdate() methods of the RawECDSA subclass are, also, updated to use the java implementation, if one has been initialized.

Signed-off by: Kostas Tsiounis kostas.tsiounis@ibm.com

keithc-ca commented 3 months ago

Please update the commit message, so the summary better captures what this change is about and add some detail to the body of the commit message: that's the best place for the information for someone looking at this years later.

KostasTsiounis commented 3 months ago

Is that OK?

keithc-ca commented 3 months ago

Jenkins test sanity zlinux jdknext

keithc-ca commented 3 months ago

Grinders: