Revert "Temporarily restore Thread/ThreadGroup suspend/resume/stop" (#729)

ibmruntimes / openj9-openjdk-jdk

Extensions for OpenJDK for Eclipse OpenJ9

GNU General Public License v2.0

17 stars 73 forks source link

Revert "Temporarily restore Thread/ThreadGroup suspend/resume/stop" (#729) #818

Closed LongyuZhang closed 1 month ago

LongyuZhang commented 1 month ago

Revert "Temporarily restore Thread/ThreadGroup suspend/resume/stop", https://github.com/ibmruntimes/openj9-openjdk-jdk/pull/729 Related Issue: https://github.com/eclipse-openj9/openj9/issues/18758

LongyuZhang commented 1 month ago

The copyright year has been updated. Thanks.

LongyuZhang commented 1 month ago

Test Links: JDK23

Reproduce the error with re-build jdk: hyc_grinder_42329
Passed on alinux sanity.functional: hyc_grinder_42413
Passed on alinux extended.functional: hyc_grinder_42414
Passed on xlinux sanity.functional: hyc_grinder_42411
Passed on xlinux extended.functional: hyc_grinder_42415 JDK21 for verify:
Passed on xlinux sanity.functional: hyc_grinder_42419
Passed on xlinux sanity.functional: hyc_grinder_42418
Passed on alinux sanity.functional: hyc_grinder_42416
Passed on alinux sanity.functional: hyc_grinder_42417 @llxia Could you review it? Thanks.

keithc-ca commented 1 month ago

This would be better described as reverting #729.

LongyuZhang commented 1 month ago

This would be better described as reverting #729.

Updated the description. Thanks.

keithc-ca commented 1 month ago

Please also update the commit message. It should be more like this:

Revert "Temporarily restore Thread/ThreadGroup suspend/resume/stop"

This reverts commit d987abcc506196944c49f1293ba4cd9eb0d3ee81.

LongyuZhang commented 1 month ago

Please also update the commit message. It should be more like this:
Revert "Temporarily restore Thread/ThreadGroup suspend/resume/stop"

This reverts commit d987abcc506196944c49f1293ba4cd9eb0d3ee81.

Updated the commit description as above. Thanks.

keithc-ca commented 1 month ago

The commit message is not formatted properly. The first line should be a summary, the second line should be blank. The third and subsequent lines, if present, provide more details. See also https://github.com/eclipse/omr/blob/master/CONTRIBUTING.md#commit-guidelines.

This has little to do with fixing tests; the commit message should be as suggested in https://github.com/ibmruntimes/openj9-openjdk-jdk/pull/818#issuecomment-2258423366.

LongyuZhang commented 1 month ago

Please also update the commit message. It should be more like this:
Revert "Temporarily restore Thread/ThreadGroup suspend/resume/stop"

This reverts commit d987abcc506196944c49f1293ba4cd9eb0d3ee81.

Updated. Thanks.

keithc-ca commented 1 month ago

Jenkins test sanity amac jdknext

keithc-ca commented 1 month ago

The test failures are unrelated to this change.