search

ibmruntimes / openj9-openjdk-jdk

Extensions for OpenJDK for Eclipse OpenJ9
GNU General Public License v2.0
17 stars 73 forks source link

Add metadata files needed to build jdk.jfr module #833

Closed thallium closed 1 week ago

tajila commented 1 week ago

@thallium update the copywrite ignore list https://github.com/ibmruntimes/openj9-openjdk-jdk/blob/openj9/.copyrightignore to include the two new files

tajila commented 1 week ago

https://github.com/ibmruntimes/openj9-openjdk-jdk/blob/openj9/buildenv/jenkins/jobs/infrastructure/copyrightCheckDir.sh may also need to be updated

thallium commented 1 week ago

@tajila Looks like buildenv/jenkins/jobs/infrastructure/copyrightCheck is being run and it respects .copyrightignore file.

thallium commented 1 week ago

@keithc-ca sorry I didn't notice the comment on copyrightCheckDir.sh yesterday, can you check if I have made the intended changes?

keithc-ca commented 1 week ago

@pshipton and @tajila: please confirm your agreement that the metadata files can be included here even though their copyright notices don't contain the classpath exception.

tajila commented 1 week ago

@pshipton and @tajila: please confirm your agreement that the metadata files can be included here even though their copyright notices don't contain the classpath exception.

Yes, confirming that the metadata files can be included.

pshipton commented 1 week ago

Confirmed.

tajila commented 6 days ago

@thallium Please add backports for JDK23, 21, 17 and 11