search

ibmruntimes / openj9-openjdk-jdk

Extensions for OpenJDK for Eclipse OpenJ9
GNU General Public License v2.0
17 stars 75 forks source link

Add more granular digest flags #862

Closed KostasTsiounis closed 3 weeks ago

KostasTsiounis commented 3 weeks ago

Instead of just having a single flag to enable/disable native support for all digest algorithms, separate flags are created for each one of them.

Signed-off-by: Kostas Tsiounis kostas.tsiounis@ibm.com

keithc-ca commented 3 weeks ago

The commit message should be corrected to say "flags" (instead of "flag") like the summary here.

keithc-ca commented 3 weeks ago

Jenkins test sanity zlinux jdknext

KostasTsiounis commented 3 weeks ago

I checked the failing tests and I noticed that I had the wrong class for SHA384 and SHA512. I fixed that with a new commit. Could we rerun the tests?

keithc-ca commented 3 weeks ago

Could we rerun the tests?

Yes, but please squash first.

KostasTsiounis commented 3 weeks ago

Could we rerun the tests?

Yes, but please squash first.

Done.

keithc-ca commented 3 weeks ago

Jenkins test sanity zlinux jdknext

keithc-ca commented 3 weeks ago

The test failures are not new; the same failures occur with a recent acceptance build - see https://openj9-jenkins.osuosl.org/job/Grinder/3896.