Include vcruntime140_1.dll when compiling with VS2019

ibmruntimes / openj9-openjdk-jdk11

Extensions for OpenJDK 11 for Eclipse OpenJ9

GNU General Public License v2.0

31 stars 112 forks source link

Include vcruntime140_1.dll when compiling with VS2019 #574

Closed pshipton closed 2 years ago

pshipton commented 2 years ago

Internal issue - JVMJ9VM011W Unable to load j9jit29: JVMPORT015E Unable to resolve shared library references - a prerequisite shared library may be missing

The OpenJDK code is backported from jdk17. 8242468: VS2019 build missing vcruntime140_1.dll

In the PR build, vcruntime140_1.dll is included in the bin directory and the java.base.jmod (as expected). On a system without vcruntime140_1.dll, the PR build runs without error, while the last nightly build gets the error shown above.

Signed-off-by: Peter Shipton Peter_Shipton@ca.ibm.com

pshipton commented 2 years ago

jenkins compile win jdk11

pshipton commented 2 years ago

jenkins compile win jdk11

pshipton commented 2 years ago

jenkins compile win jdk11

babsingh commented 2 years ago

Why didn't we change the copyright to 2022?
Otherwise, LGTM.

pshipton commented 2 years ago

The OpenJDK changes backported were made in 2020, so I used that date.

pshipton commented 2 years ago

@keithc-ca do you have an opinion on what copyright date to use?

keithc-ca commented 2 years ago

I think we should also backport the copyright dates from jdk17.

keithc-ca commented 2 years ago

@babsingh Why did you merge this before @pshipton had a chance to update the copyright dates?

babsingh commented 2 years ago

As per https://github.com/ibmruntimes/openj9-openjdk-jdk11/pull/574#issuecomment-1242545375, the copyrights already matched the original changes.
As per https://github.com/ibmruntimes/openj9-openjdk-jdk11/pull/574#issuecomment-1243917089, you wanted the copyrights from the original changes to be used.
So, no more changes were needed.

babsingh commented 2 years ago

@keithc-ca Was your message misinterpreted? I can make the correction.

keithc-ca commented 2 years ago

Perhaps I didn't look at the dates closely enough. For example, spec.gmk.in has a current copyright date in jdk17 of 2021, but this change leaves that date at 2020: that sort of discrepancy was the basis for my comment. However, if we consider the date when the change was committed to jdk17, it is actually 2020, so I think everything is fine. Sorry for the noise.