Include PRODUCT_SUFFIX in J9PRODUCT_NAME

[pshipton]

Issue https://github.com/eclipse-openj9/openj9/issues/16449

Tested via https://openj9-jenkins.osuosl.org/job/Pipeline-Build-Test-Personal/312/ along with https://github.com/pshipton/openj9/tree/prodsuffix

With --with-product-suffix="OpenPete Edition":

-Xinternalversion Eclipse OpenJ9 OpenJDK OpenPete Edition 64-bit Server VM (11.0.18-internal+0-adhoc.jenkins.BuildJDK11aarch64macPersonal) from macosx-aarch64 JRE with Extensions for OpenJDK for Eclipse OpenJ9 11.0.18.0-ea, built on Dec 13 2022 ... (removed the trailing build id and compiler info for clarity)

javacore contains 1CIPRODUCT OpenJDK OpenPete Edition

---

Also https://openj9-jenkins.osuosl.org/job/Pipeline-Build-Test-Personal/313/ that doesn't set a product suffix. However there is a default set in https://github.com/ibmruntimes/openj9-openjdk-jdk11/blob/openj9/make/autoconf/version-numbers#L44

-Xinternalversion Eclipse OpenJ9 OpenJDK Runtime Environment 64-bit Server VM (11.0.18-internal+0-adhoc.jenkins.BuildJDK11aarch64macPersonal) from macosx-aarch64 JRE with Extensions for OpenJDK for Eclipse OpenJ9 11.0.18.0-ea, built on Dec 13 2022 ...

javacore contains 1CIPRODUCT OpenJDK Runtime Environment

---

Previous behaviour:

-Xinternalversion Eclipse OpenJ9 OpenJDK 64-bit Server VM (11.0.18-internal+0-adhoc.jenkins.BuildJDK11aarch64macNightly) from macosx-aarch64 JRE with Extensions for OpenJDK for Eclipse OpenJ9 11.0.18.0-ea, built on Dec 10 2022 ...

javacore contains 1CIPRODUCT OpenJDK

[pshipton]

I'll work on the other versions after this is reviewed.

[keithc-ca]

Jenkins compile amac jdk11