search

ibmruntimes / openj9-openjdk-jdk11

Extensions for OpenJDK 11 for Eclipse OpenJ9
GNU General Public License v2.0
31 stars 112 forks source link

Cloneable test in HmacCore seems questionable #667

Closed WilburZjh closed 1 year ago

WilburZjh commented 1 year ago

This is a backport PR from JDK17 PR https://github.com/ibmruntimes/openj9-openjdk-jdk17/commit/b88cc7219e1bd53bda2adefa8cfffb3bfbc0f8f9 to JDK11.

WilburZjh commented 1 year ago

Hi @keithc-ca , please help to review.

keithc-ca commented 1 year ago

In the future, please ensure commit messages contain enough information that someone reviewing it years down the road will understand the change and why it was made.

keithc-ca commented 1 year ago

Jenkins test sanity osx jdk11

pshipton commented 1 year ago

Does this update need to go into the the 0.40 release?

keithc-ca commented 1 year ago

Does this update need to go into the the 0.40 release?

I think it should (assuming it doesn't cause any issues in the main branch).

pshipton commented 1 year ago

Created https://github.com/ibmruntimes/openj9-openjdk-jdk11/pull/668 for 0.40