search

ibmruntimes / openj9-openjdk-jdk11

Extensions for OpenJDK 11 for Eclipse OpenJ9
GNU General Public License v2.0
31 stars 112 forks source link

Add NotCheckpointSafe annotations to PhantomCleanable #750

Closed singh264 closed 9 months ago

singh264 commented 10 months ago

Add NotCheckpointSafe annotations to PhantomCleanable to avoid blocking operations during restore in CRIU single thread mode, and fix the failures in the cmdLineTester_criu_nonPortableRestore tests that occur due to blocking operations during restore in CRIU single thread mode.

Issue: https://github.com/eclipse-openj9/openj9/issues/18749 Signed-off-by: Amarpreet Singh Amarpreet.A.Singh@ibm.com

singh264 commented 10 months ago

@tajila requesting your review.

TobiAjila commented 10 months ago

@JasonFengJ9 please review/merge

JasonFengJ9 commented 9 months ago

jenkins test sanity xmac,alinux64 jdk11

keithc-ca commented 9 months ago

This should not have been merged until after equivalent changes have been applied to later versions (jdk17, jdk21, jdk22, jdknext). @singh264 Please prepare changes for those versions.

JasonFengJ9 commented 9 months ago

@keithc-ca those equivalent changes were merged a while ago, this is the Java level not applied initially.

https://github.com/eclipse-openj9/openj9/issues/18749#issuecomment-1889793364

keithc-ca commented 9 months ago

I see that now. Sorry for the interruption.