search

ibmruntimes / openj9-openjdk-jdk11

Extensions for OpenJDK 11 for Eclipse OpenJ9
GNU General Public License v2.0
31 stars 112 forks source link

Show error message for --with-cmake=no on AArch64 macOS. #780

Closed knn-k closed 5 months ago

knn-k commented 5 months ago

OpenJ9 build for AArch64 macOS requires Cmake. This commit shows an error message when --with-cmake=no is specified on the platform.

knn-k commented 5 months ago

I am going to open PRs for jdk17/21/22/next after this PR is approved.

pshipton commented 5 months ago

OpenJ9 build for AArch64 macOS requires Cmake

Pls explain why,

knn-k commented 5 months ago

Because the spec file for AArch64 macOS is missing in https://github.com/eclipse-openj9/openj9/tree/master/buildspecs/. The UMA build fails with the following message:

Universal Makefile Adapter - for J9, version 2.5.1

Could not find osx_aarch64.spec file.
keithc-ca commented 5 months ago

Perhaps a better solution would be to create osx_aarch64.spec?

knn-k commented 5 months ago

I opened https://github.com/eclipse-openj9/openj9/issues/19501. Closing this PR.

knn-k commented 5 months ago

@keithc-ca Are there any document available that describes the meaning of properties and flags in the build spec files for UMA build?

keithc-ca commented 5 months ago

any document available that describes the meaning of properties and flags in the build spec files for UMA build?

See https://github.com/eclipse-openj9/openj9/issues/19501#issuecomment-2115662054.