ibmruntimes / openj9-openjdk-jdk21

GNU General Public License v2.0
8 stars 40 forks source link

Support restore with -XX:CRaCRestoreFrom=PATH #142

Closed singh264 closed 1 month ago

singh264 commented 7 months ago

Support restore with -XX:CRaCRestoreFrom=PATH that specifies the path to the checkpoint image.

Issue: https://github.com/eclipse-openj9/openj9/issues/19261 Signed-off-by: Amarpreet Singh Amarpreet.A.Singh@ibm.com

singh264 commented 7 months ago

@tajila requesting your review.

It seems like this code change would need to be ported to jdk11, jdk17, jdk22 and jdk-next.

tajila commented 7 months ago

@JasonFengJ9 Please review

tajila commented 7 months ago

Normally we do JDKnext first then backport

JasonFengJ9 commented 7 months ago

Normally we do JDKnext first then backport

Please make a PR at https://github.com/ibmruntimes/openj9-openjdk-jdk for reviewing.

In addition, the code added in this change should be decorated with #if defined(J9VM_OPT_CRAC_SUPPORT), and j9cfg.h needs to be included.

singh264 commented 7 months ago

Please make a PR at https://github.com/ibmruntimes/openj9-openjdk-jdk for reviewing.

I have opened a PR at https://github.com/ibmruntimes/openj9-openjdk-jdk for reviewing.

JasonFengJ9 commented 1 month ago

Superseded by https://github.com/ibmruntimes/openj9-openjdk-jdk21/pull/199