search

ibmruntimes / openj9-openjdk-jdk9

Extensions for OpenJDK for Eclipse OpenJ9
GNU General Public License v2.0
67 stars 76 forks source link

OpenJ9 Java 9 extension doesn't have latest level #136

Closed JasonFengJ9 closed 6 years ago

JasonFengJ9 commented 6 years ago

Class jdk.internal.misc.Unsafe in current OpenJ9 branch still refers obsoleted method allocateDBBMemory, allocateDBBMemory, freeDBBMemory such as https://github.com/ibmruntimes/openj9-openjdk-jdk9/blob/openj9/jdk/src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template#L100, while the master branch refers to allocateMemory, allocateMemory, freeMemory instead such as https://github.com/ibmruntimes/openj9-openjdk-jdk9/blob/master/jdk/src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template#L94.

This suggests OpenJ9 Java 9 branch doesn't have latest level updates.

FYI: @theresa-m @DanHeidinga @pshipton

DanHeidinga commented 6 years ago

My understanding is that master branch contains the unpatched OpenJDK code while the openj9 branch includes the modifications necessary to run OpenJ9.

JasonFengJ9 commented 6 years ago

Right, that's my understanding as well. The difference shown in this issue is not due to the modification to run OpenJ9, it just doesn't get latest OpenJDK update. Latest OpenJDK Java 9 b181 replaced allocateDBBMemory, allocateDBBMemory, freeDBBMemory with allocateMemory, allocateMemory, freeMemory though I am not sure exactly when the API were changed.

DanHeidinga commented 6 years ago

The DBB family of functions (allocateDBBMemory and friends) are OpenJ9 extensions. They haven't been in OpenJDK (yet)

JasonFengJ9 commented 6 years ago

Thanks @DanHeidinga for the clarification. Closing this issue accordingly.