ibmruntimes / openj9-openjdk-jdk9

Extensions for OpenJDK for Eclipse OpenJ9
GNU General Public License v2.0
67 stars 76 forks source link

Add java.util.Arrays patch to use gpu module code #142

Closed theresa-m closed 6 years ago

theresa-m commented 6 years ago

Fixes: https://github.com/eclipse/openj9/issues/189

Dependent PR: https://github.com/eclipse/openj9/pull/1485

Signed-off-by: Theresa Mammarella Theresa.T.Mammarella@ibm.com

theresa-m commented 6 years ago

Can someone please advise on what is incorrect with the Arrays.java copyright?

DanHeidinga commented 6 years ago

FAILURE - Copyright date in file: 'jdk/src/java.base/share/classes/java/util/Arrays.java' appears to be incorrect

My guess would be a missing comma between 2018 2018

DanHeidinga commented 6 years ago
+/*
 + * Licensed Materials - Property of IBM
 + * RMI-IIOP v1.0
 + * Copyright IBM Corp. 2018 2018  All Rights Reserved
 + *
 + */

This doesn't match the copyrights in other files in this repo. Are you sure this is correct?

theresa-m commented 6 years ago

I found some java files with that copyright - mostly in the corba directory. Found this one as well:

/*
 * ===========================================================================
 *
 * (C) Copyright IBM Corp. 2003 All Rights Reserved.
 *
 * ===========================================================================
 */
DanHeidinga commented 6 years ago

Corba may be a special case due to the development of the initial implementation.

theresa-m commented 6 years ago

got it. thanks @DanHeidinga !

theresa-m commented 6 years ago

^ Moved GPUAssistHolder.java to separate java file in eclipse/openj9 repo (see eclipse/openj9#1485)