Add OSX compressedrefs support in openj9-openjdk-jdk9

ibmruntimes / openj9-openjdk-jdk9

Extensions for OpenJDK for Eclipse OpenJ9

GNU General Public License v2.0

67 stars 76 forks source link

Add OSX compressedrefs support in openj9-openjdk-jdk9 #179

Closed babsingh closed 5 years ago

babsingh commented 5 years ago

Set OPENJ9_BUILDSPEC to osx_x86-64_cmprssptrs for compressedrefs build.

Append "-pagezero_size 0x1000" to LDFLAGS_JDKEXE on OSX 64-bit compressedrefs build. This allows memory to be mapped below 4GB.

Ran ./common/autoconf/autogen.sh to re-generate the generated-configure.sh scripts.

Signed-off-by: Babneet Singh sbabneet@ca.ibm.com

babsingh commented 5 years ago

fyi - @DanHeidinga

DanHeidinga commented 5 years ago

The copyright check is expected to fail for the generated files.

DanHeidinga commented 5 years ago

@babsingh Is this ready? I'm OK with merging once the WIP tag is removed,

babsingh commented 5 years ago

Yes, these changes are ready. I wanted to verify if these changes work with the OpenJ9 spec file changes. Since these are front-end changes and other platforms use the same code, so these changes should work regardless. Thus, removing the WIP tag.

babsingh commented 5 years ago

@DanHeidinga I have added -pagezero_size changes for compressedrefs build, and rebased to clear the conflicts. I can successfully build compressedrefs:

openjdk version "9.0.4-internal"
OpenJDK Runtime Environment (build 9.0.4-internal+0-adhoc.sbabneetcaibmcom.openj9-openjdk-jdk9)
Eclipse OpenJ9 VM (build osx_compressedrefs-e2a35e14a9, JRE 9 Darwin amd64-64-Bit Compressed References 20181010_000000 (JIT enabled, AOT enabled)
OpenJ9   - e2a35e14a9
OMR      - 57dd0f0b
JCL      - 47987161dc based on jdk-9.0.4+12)

DanHeidinga commented 5 years ago

@keithc-ca Any objections to this approach? I'm OK with it but not as well versed in the ojdk makefiles